-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hack-15): Remove unused notification permissions #11436
base: main
Are you sure you want to change the base?
fix(hack-15): Remove unused notification permissions #11436
Conversation
@@ -2677,7 +2677,7 @@ SPEC CHECKSUMS: | |||
appcenter-core: 3f5907606dfbf4ffe62cb7798210174c2608a7d9 | |||
AppCenterReactNativeShared: 01df23849b1c3c6eb8c4049f54322635650e98f0 | |||
Base64: cecfb41a004124895a7bcee567a89bae5a89d49b | |||
boost: 4cb898d0bf20404aab1850c656dcea009429d6c1 | |||
boost: 1dca942403ed9342f98334bf4c3621f011aa7946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes persisted after running pod update boost fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice - not sure why the keeeeeeep coming
@@ -2677,7 +2677,7 @@ SPEC CHECKSUMS: | |||
appcenter-core: 3f5907606dfbf4ffe62cb7798210174c2608a7d9 | |||
AppCenterReactNativeShared: 01df23849b1c3c6eb8c4049f54322635650e98f0 | |||
Base64: cecfb41a004124895a7bcee567a89bae5a89d49b | |||
boost: 4cb898d0bf20404aab1850c656dcea009429d6c1 | |||
boost: 1dca942403ed9342f98334bf4c3621f011aa7946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice - not sure why the keeeeeeep coming
This PR resolves []
Important
This change is part of Migrating push to Pulse hackathon project
Description
This PR is a prerequisite to artsy/gravity#18498 🔒 and artsy/gravity#18503 🔒 to clean up gravity and move all push notification login to Pulse
This PR removes
New Viewing Rooms for You
andNew Shows for You
notification permissions since they haven't been used for quite some timeScreenshots
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.