Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hack-15): Remove unused notification permissions #11436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Jan 23, 2025

This PR resolves []

Important

This change is part of Migrating push to Pulse hackathon project

Description

This PR is a prerequisite to artsy/gravity#18498 🔒 and artsy/gravity#18503 🔒 to clean up gravity and move all push notification login to Pulse

This PR removes New Viewing Rooms for You and New Shows for You notification permissions since they haven't been used for quite some time

Screenshots

Before After
Android image image
iOS image image

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Remove New Viewing Rooms for You and New Shows for You notification permission

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@@ -2677,7 +2677,7 @@ SPEC CHECKSUMS:
appcenter-core: 3f5907606dfbf4ffe62cb7798210174c2608a7d9
AppCenterReactNativeShared: 01df23849b1c3c6eb8c4049f54322635650e98f0
Base64: cecfb41a004124895a7bcee567a89bae5a89d49b
boost: 4cb898d0bf20404aab1850c656dcea009429d6c1
boost: 1dca942403ed9342f98334bf4c3621f011aa7946
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes persisted after running pod update boost fmt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice - not sure why the keeeeeeep coming

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (Remove New Viewing Rooms for You and New Shows for You notification permission - MrSltun)

Generated by 🚫 dangerJS against 3bb7d3b

@@ -2677,7 +2677,7 @@ SPEC CHECKSUMS:
appcenter-core: 3f5907606dfbf4ffe62cb7798210174c2608a7d9
AppCenterReactNativeShared: 01df23849b1c3c6eb8c4049f54322635650e98f0
Base64: cecfb41a004124895a7bcee567a89bae5a89d49b
boost: 4cb898d0bf20404aab1850c656dcea009429d6c1
boost: 1dca942403ed9342f98334bf4c3621f011aa7946
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice - not sure why the keeeeeeep coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants