Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ☯️ #11417

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Support ☯️ #11417

wants to merge 3 commits into from

Conversation

MounirDhahri
Copy link
Member

#hackathon

Description

☯️☯️☯️☯️

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add dark mode - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Jan 21, 2025
@MounirDhahri MounirDhahri force-pushed the feat/support-dark-mode branch from debe767 to 4d3f25f Compare January 21, 2025 14:22
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 21, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (add dark mode - mounir - MounirDhahri)

Generated by 🚫 dangerJS against 1d57fef

package.json Outdated
@@ -223,6 +223,7 @@
"@react-native/eslint-config": "0.76.5",
"@react-native/metro-config": "0.76.5",
"@react-native/typescript-config": "0.76.5",
"@sentry/cli": "2.41.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep this out of package json ;P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to raise this actually. It's true that it's not used unless one is trying to use code-push, I wonder though if it's really worth it to remove it since it's anyway a dev dependency and it won't affect users but it will slow us down from create code-push canaries

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the reason why it was removed as a dev dependency in the first place #10767

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising that, although it's not a dev dependency, I feel like it's useful to have it there. Currently, I am making many code-push releases and adjusting my code often and testing again.
However each time I want to commit some code, I had to be careful not to commit yarn.lock and package.json after creating a beta.

Screenshot 2025-01-21 at 17 41 28

I am fine with keeping on doing that but I don't see any harm in adding it again.

@MounirDhahri MounirDhahri force-pushed the feat/support-dark-mode branch 11 times, most recently from eb3e5c4 to 5138a70 Compare January 23, 2025 11:24
@MounirDhahri MounirDhahri force-pushed the feat/support-dark-mode branch from 5138a70 to 0eba512 Compare January 23, 2025 11:25
@MounirDhahri MounirDhahri force-pushed the feat/support-dark-mode branch from d21144f to 1d57fef Compare January 23, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants