-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ☯️ #11417
base: main
Are you sure you want to change the base?
feat: Support ☯️ #11417
Conversation
debe767
to
4d3f25f
Compare
package.json
Outdated
@@ -223,6 +223,7 @@ | |||
"@react-native/eslint-config": "0.76.5", | |||
"@react-native/metro-config": "0.76.5", | |||
"@react-native/typescript-config": "0.76.5", | |||
"@sentry/cli": "2.41.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep this out of package json ;P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to raise this actually. It's true that it's not used unless one is trying to use code-push, I wonder though if it's really worth it to remove it since it's anyway a dev dependency and it won't affect users but it will slow us down from create code-push canaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the reason why it was removed as a dev dependency in the first place #10767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising that, although it's not a dev dependency, I feel like it's useful to have it there. Currently, I am making many code-push releases and adjusting my code often and testing again.
However each time I want to commit some code, I had to be careful not to commit yarn.lock
and package.json
after creating a beta.
I am fine with keeping on doing that but I don't see any harm in adding it again.
eb3e5c4
to
5138a70
Compare
5138a70
to
0eba512
Compare
d21144f
to
1d57fef
Compare
#hackathon
Description
☯️☯️☯️☯️
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.