Make blending (in scaling) respect alpha #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sampling from multiple pixels to implement scaling (only relevant for anti-aliasing), the sampled values should be multiplied by their alpha value to prevent colors "bleeding" from almost-transparent regions. Consider this image, which consists of a square in the center with color #00ff00ff and a border of #ff000001:
Without multiplying by the alpha, we can get unexpected red in the border region, as seen here with anti-aliasing on (so bicubic):
This is because the alpha values are higher there from the green square, but the red component is stronger than it should be.
With the PR gives: