Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ConstraintSynthesizer trait with closure type alias #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MozirDmitriy
Copy link

@MozirDmitriy MozirDmitriy commented Jan 18, 2025

Description:
Addresses TODO comment by replacing the ConstraintSynthesizer trait with a type alias for a boxed closure. This change:

  • Simplifies the constraint system interface
  • Maintains the same functionality
  • Makes the code more flexible by allowing direct use of closures
  • Removes unnecessary trait boilerplate since the trait only had one method

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Description:
Addresses TODO comment by replacing the ConstraintSynthesizer trait with a type alias for a boxed closure. This change:
- Simplifies the constraint system interface
- Maintains the same functionality
- Makes the code more flexible by allowing direct use of closures
- Removes unnecessary trait boilerplate since the trait only had one method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant