Add benchmark templates and sample benches for IPA #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Antonio Mejías Gil <[email protected]>
mmagician
requested review from
z-tech,
Pratyush and
weikengchen
and removed request for
a team
Pratyush
reviewed
Oct 26, 2023
benches/benches.rs
Outdated
| @@ -0,0 +1,57 @@ | |||
| // #![cfg(feature = "benches")] | |||
There was a problem hiding this comment.
Suggested change
| // #![cfg(feature = "benches")] |
Pratyush
reviewed
Oct 26, 2023
Cargo.toml
Outdated
Comment on lines
28
to
29
| criterion = { version = "0.5", default-features = false, optional = true } | ||
| rand_chacha = { version = "0.3.0", default-features = false, optional = true } |
There was a problem hiding this comment.
hm we don't want criterion as a normal dependency, as it has too many dependencies. criterion should be a dev-dependency.
There was a problem hiding this comment.
Also, rand_chacha is already a dev-dependency.
Pratyush
reviewed
Oct 26, 2023
src/bench_templates/mod.rs
Outdated
| @@ -0,0 +1,241 @@ | |||
| use ark_crypto_primitives::sponge::{ | |||
There was a problem hiding this comment.
We can make this a file in benches, or extract it into a separate crate (ala ark-algebra-bench-templates)
|
Thanks @Pratyush, I've refactored the bench templates into its own crate as suggested. This required creating a workspace, so there's a bunch of files moved around, but ultimately the actual changes are few and much more elegant. Adding benches for a new scheme will also hopefully be simpler. |
Pratyush
requested changes
Oct 28, 2023
Pratyush
approved these changes
Oct 29, 2023
mmagician
added a commit
to NP-Eng/poly-commit
that referenced
this pull request
Nov 15, 2023
* Add benchmark templates and sample benches for IPA Co-authored-by: Antonio Mejías Gil <[email protected]> * adapt max poly degree to 20 * Move all PC Schemes to one module; bench-templates as a separate module * inline one of the type aliases * remove commented out comment * Add benchmark instructions to the README * make bench-templates non publishable * fix yaml file: remove newline * rename the inner dir to `poly-commit` * rename usages of `pcs` to `poly-commit` --------- Co-authored-by: Antonio Mejías Gil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer