See my changes, as professionals. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create style.css
Create icons.svg
Create script.js
Upload JS-scripts.
Uploading files here.
Armory.js - updated.
Electrum.js - updated.
Convertations between transparent-address.
Brainwallet.js - updated. See readme.md
See readme.md
Changes - in readme.md
The changes are described here.
write as strings.
add whitespaces
Because not been included.
And delete from there...
Move this file.
Move this file.
Bitcoin is standart. Geertcoin used just for test. There is compressed keys. If any parameters not specified in array, using default defined parameters.
Add link to the wirking site for tests and link to the source code.
Fix link with href to the root directory
Not using here.
This not working in my Mozilla Firefox, only in Google Chrome, so max-height is 800px, now.
Fix readonly rextarea and base64 uploading for all files. Now this available only for RAW-data.
Bitcoin now default again. After copy and paste the code. :)
username1565
changed the title
More readable.
Now contend from uploaded as base64 only if raw selected in converter.
Now if unsigned character was been found - source encoding automatically switching from text to base64. Title added as attribute to the textarea in converter.
Now this working for all textareas, like "sign", "verify" tabs.
Now UTF-8 encoded text can be correct encoded and decoded. UTF-8 text as ASCII symbols can be decoded to UTF as text.
Changed files: - index.html - js/brainwallet.js - js/bitcoinsig.js - css/brainwallet.css Changes: - Add strMessageMagic to the functions for sign and verify digital signatures. Now signing and verify message is compatible with all another altcoin-clients. You can extract strMessageMagic-parameter from the source code of your altcoin. (This contains file main.cpp, or validation.cpp). strMessageMagic value - can be specified in index.html as attribute for altcoin item in the select menu list. See the source code. - Add strMessageMagic to permalink, as separate parameter, with escaped value. Now permalink validation is available. - Add strMessageMagic as attribute in index.html for LiteCoin, VertCoin, Signatum, GeertCoin, BeachCoin. About some altcoins: Signatum mainnet - not working. No one holder not staking and this is POS coin. Transactions is unconfirmed without POS blocks. Only yobit closed subnetwork have blockchain with highest height. No public addnodes from yobit sub-network. Geertcoin delisted from ctyptopia and some pools. Transaction cann't be confirmed, because no one cann't mining with scrypt-algorithm, using GPU. Need scrypt-ASIC's, but no one not doing solo-mining this coin, without pools. I did leave this coins just for test signatures. - Add function to test signature in bitcoinsig.js. This try to verify signed message, then resign this and verify again. Uncomment this in bitcoinsig.js and see console.log (F12 button) - Test signing and verify messages in brainwallet, in qt-wallets, and another services. See comments in the source code. - Add DASH + strMessageMagic. Compressed and uncompressed keys and addressed - available. - Fix scrollable menu with list of coins parameters. 1. change two column menu to one column. 2. change width to 200px. Now all letters are displayed good. 3. change max-height to 500px. 4. test scolling this menu in different browsers. Best regards.
changed files: - index.html - brainwallet.js - electrum.js - armory.js - bitcoinsig.js added files: - web3-eth-accounts.js Changes: - Add ethereum (web3-eth-accounts.js + empty file web3-eth-accounts.js.map). -- Add Ethereum in dropdown menu. -- Hex -> to Ethereum privkey. Fix key length if this hex not contains 32 bytes. -- Privkey -> to Ethereum address -- Change size to 5 - for qrcode of ethereum private key. -- Fix addition slash in the link to block-explorers for qr-code with address. -- Armory and Electrum chains supporting Ethereum now. width for chain list changed to 1000px to display ethereum list fully. -- Sign and verify message on client-sied - supporting Ethereum now. Add notification for not supporting methods. -- Verify lowerCase address, like specified here: https://www.myetherwallet.com/signmsg.html Switch ETH address to LowerCase automatically. -- Key_file - now can be available to download 32-byte keyfile, corresponding to Ethereum privkey. -- Add notification with link on MyEtherWallet in Transactions tab. Make all fields readonly when Ethereum selected. -- Add title tooltip when ethereum privkey entered, but ETH - not selected in dropdown menu. -- Add ethereum to test signature function. See commented code in bitcoinsig.js -- Add speed test code to test signing and verify messages (commented in bitcoinsig.js). - Add regenerate address from privkey, on Transactions tab, when another coin selected in dropdown menu. - Fix console.log error on transactions tab: Uncaught SyntaxError: Unexpected end of input, when unspent outputs not loaded. - Add timeout for generate keys, using Armory and Electrum determininstic chains generators. Now list of chains filling slowly. See source code.
Just add guncoin
Comment the code to don't show that window, about confirm the loading transaction.
Guncoin using uncompressed keys and addresses
comment this all
Add strMessageMagic = "Guncoin Signed Message:\n" from https://github.com/guncoin/guncoin/blob/master/src/validation.cpp to make working signing and verifying the messages. See this issue: #1
index.html - Add strMessageMagic for CGUR to sign and verify signed messages, switch address to compressed. - Add '\n' for "from" and "to" buttons in the section of converter. brainwallet.js - Add supporting to convert data to "string with decimal values of bytes, separated with comma", and convert from this. - Add supporting permalink for converter, to convert data by using different ways. - Comment old test-code in brainwallet.js, at lines 1748-1767, to don't try to connect blockchain-site, when coin selected in dropdown-menu.
Add GALE there.
Try to add SafeChain (SFC). Source code here: https://github.com/safechaincrypto/blockchain I'm not sure, private key prefix is valid, but https://username1565.github.io/brainwallet.github.io/#converter show me value "0x99", after I did the following steps: 1. In safechain console write the following commands: getnewaddress -> generated_address -> copy this. 2. dumpprivkey generated_address -> private_key -> copy this. private_key beginning from "P". 3. Paste this in https://username1565.github.io/brainwallet.github.io/#converter and try to convert this from Base58Check. See version 0x99, and length of privkey 33 bytes, with 01 in the end of hex. Seems like compressed privkey and address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this can be strongly optimized. All changes are described in README.md