Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reassigning a parameter value to fix Pyright warnings #3106

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

correctmost
Copy link
Contributor

PR Description:

This PR fixes the following Pyright warnings:

archinstall/lib/configuration.py:131:26 - error: Argument of type "Path | None" cannot be assigned to parameter "dest_path" of type "Path" in function "_is_valid_path"
    Type "Path | None" is not assignable to type "Path"
      "None" is not assignable to "Path" (reportArgumentType)
archinstall/lib/configuration.py:132:26 - error: Argument of type "Path | None" cannot be assigned to parameter "dest_path" of type "Path" in function "save_user_config"
    Type "Path | None" is not assignable to type "Path"
      "None" is not assignable to "Path" (reportArgumentType)
archinstall/lib/configuration.py:133:25 - error: Argument of type "Path | None" cannot be assigned to parameter "dest_path" of type "Path" in function "save_user_creds"
    Type "Path | None" is not assignable to type "Path"

@correctmost correctmost requested a review from Torxed as a code owner January 11, 2025 20:25
@svartkanin svartkanin merged commit 47736c4 into archlinux:master Jan 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants