[No.129]Function with the ability to select cells (Data filter B… #536

sanglevinh · 2024-12-23T08:45:28Z

[No.129]Function with the ability to select cells (Data filter Button) #516

…utton)

- make workflow/node's run status constant. - rename some symbols

- refactor node pickle data operation - clarification of processing, improvement of error handling, etc.

- refactor SmkStatusLogger operation - improved node status updates on errors throughout workflow

- refactor ConfigWriter modules - clarification of processing and simplification of code

- refactor workflow pid file processing - refactor cancel workflow processing

frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx

…w' into feature/516

milesAraya

Currently the filter box has bugs in the input

Cannot delete "0"
Cannot input commas into ROI
Actual data dims should be used for placeholders
Filter box parameters are not passed to the subsequent analysis. This is the whole point of the filter box. If dim 1:500 is selected, only that data should be used for the next step of analysis. This will allow users to save time by only performing analysis on certain important sections of the data. For PCA it will also change the results. This is a top priority.
Fluorescence and ROI windows should be shown simultaneously and side-by-side (this is lower priority as user could still manage to use the filter box without this. However, it was still in the request)

milesAraya · 2025-01-07T01:40:54Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+      <InputDim
+        title="ROI"
+        name="roi"
+        placeholder="1:23,50:52"


The input does not allow this input style "1:23,50:52"
Comma is not possible

@milesAraya I have fixed it.

milesAraya · 2025-01-07T02:14:33Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+      <InputDim
+        title="Dim 2"
+        name="dim2"
+        placeholder="1:128"


If you input "1:0", you cannot delete the 0 using backspace. You need to highlight the whole text and delete, or add some more numbers and then delete those

This conversation will be unresolved because the reviewer has not yet checked it.
*The reviewer should resolve the conversation.

@milesAraya I have fixed it.

milesAraya · 2025-01-07T02:16:17Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+  return (
+    <Box>
+      <Box mb={1}>{title}</Box>
+      <Input inputProps={{ style: { textAlign: "center" } }} {...p} />


I think in the powerpoint request, there were 2 side-by-side windows, with ROI and fluorescence both visible.

I think in the powerpoint request, there were 2 side-by-side windows, with ROI and fluorescence both visible.

@milesAraya
Currently, I see that the description in the PowerPoint about the UI is similar to the output UI, so I am reusing this UI for now. If we follow the PowerPoint layout, the UI will only display two side-by-side panels, right? Because the output UI has quite a few tabs.

milesAraya · 2025-01-07T02:18:34Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+
+  const { dim1, dim2, dim3, roi } = useMemo(() => {
+    return {
+      dim1: getData(dataFilterParams?.dim1),


It would be good if these dimensions, from the real data, are used in the placeholders
placeholder="1:1000" -> placeholder="1:dim3"

milesAraya · 2025-01-07T02:23:06Z

frontend/src/store/slice/AlgorithmNode/AlgorithmNodeSlice.ts

@@ -48,6 +49,19 @@ export const algorithmNodeSlice = createSlice({
        }
      }
    },
+    updateFilterParams: (
+      state,
+      action: PayloadAction<{


When i choose filter settings, these do not seem to be passed on to the next nodes.
Here i select ROI 1:30

But in the ETA visualise window all the ROI are present (e.g. 121). Only ROI 1:30 should be present

And the fluorescence dim was selected to be 1:500, but in the flourescence window 1:2000 are still visible

@milesAraya
When you change the filter parameters, please run it again to update the data. The changes will not be reflected until you run it again.

itutu-tienday · 2025-01-07T11:19:24Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+  )
+
+  return (
+    <Box display="flex" gap={2} textAlign="center" pt={2}>


Could you place the following buttons

APPLY

CANCEL

RESET

Design documents are being updated

https://docs.google.com/presentation/d/1ksXS7NZRe5BKnIyS3v2Ird539OmulOMD/edit#slide=id.p3

itutu-tienday · 2025-01-07T11:28:25Z

frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx

+              status !== NODE_RESULT_STATUS.SUCCESS || isParentParamsUpdated
+            }
+          >
+            Filter


If I apply a Filter, can I have the Node's Hilight applied only to the Filter button? (Node itself will remain white)

The design document has been updated.

https://docs.google.com/presentation/d/1ksXS7NZRe5BKnIyS3v2Ird539OmulOMD/edit#slide=id.p3

If the implementation is going to be complicated, please contact us.

itutu-tienday · 2025-01-07T11:32:41Z

frontend/src/components/Workspace/FlowChart/Dialog/AlgorithmOutputDialog.tsx

+
+  return (
+    <Box display="flex" gap={2} textAlign="center" pt={2}>
+      <InputDim


Validate must be applied to input values

Numeric values start from 1

Compare the value to a larger or smaller value

Check the upper limit of the numerical value

This requires obtaining the upper limit of the actual data. If this is difficult to handle, please contact us.

sanglevinh and others added 11 commits December 23, 2024 15:41

TODO [No.129]Function with the ability to select cells (Data filter B…

a01f454

…utton)

resolve abnormal workflow: refactor modules

bcc4e50

- make workflow/node's run status constant. - rename some symbols

resolve abnormal workflow: refactor modules

a3d7492

- refactor node pickle data operation - clarification of processing, improvement of error handling, etc.

fix linter

e3e7c52

resolve abnormal workflow: refactor modules

25cb106

- refactor SmkStatusLogger operation - improved node status updates on errors throughout workflow

resolve abnormal workflow: refactor modules

6e8b59a

- refactor ConfigWriter modules - clarification of processing and simplification of code

fix test

0d12c34

resolve abnormal workflow: refactor modules

12442b1

- refactor workflow pid file processing - refactor cancel workflow processing

fix minor bug in cancel_run

84ec063

first commit for "resolive abnormal workflow"

ebe0eaa

Done Integrate API

d69bac3

sanglevinh marked this pull request as ready for review December 27, 2024 09:10

sanglevinh changed the title ~~TODO [No.129]Function with the ability to select cells (Data filter B…~~ [No.129]Function with the ability to select cells (Data filter B… Dec 27, 2024

sanglevinh requested review from emuemuJP, itutu-tienday, milesAraya and tsuchiyama-araya December 27, 2024 09:18

itutu-tienday and others added 6 commits December 28, 2024 10:32

minor fix for WorkflowMonitor

d7d619d

add check isUpdateDataFilter

b186f9d

filter string empty in dim

8b22fdd

fix dim

816b880

fix undefined dataFilterParam

52feca6

clear dataFilterParam when run all

aba3b9c

itutu-tienday linked an issue Jan 6, 2025 that may be closed by this pull request

[No.129]Function with the ability to select cells (Data filter Button) #516

Open

itutu-tienday requested changes Jan 6, 2025

View reviewed changes

frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx Show resolved Hide resolved

frontend/src/components/Workspace/FlowChart/FlowChartNode/AlgorithmNode.tsx Show resolved Hide resolved

sanglevinh added 2 commits January 6, 2025 18:13

Fix comment.

ac71de4

Merge remote-tracking branch 'origin/feature/resolve-abnormal-workflo…

1293d41

…w' into feature/516

milesAraya requested changes Jan 7, 2025

View reviewed changes

sanglevinh added 2 commits January 7, 2025 11:47

Fix input Dim

46fbdee

reset data filter params when params parent changed

7cfbdf2

itutu-tienday requested changes Jan 7, 2025

View reviewed changes

sanglevinh added 13 commits January 13, 2025 18:14

Add Slide to Slide BoxFilter

848176c

Add 3 button accept , cancel , reset data filter params

45e5d35

fix check change filter

46d2470

Fix test

931505c

fix highlight roi

923f2db

add slice range timeseriesplot

7b457a4

fĩ dependence

db38497

fix validate to > from

2a6d8a0

fix return 0

7b05813

fix validate end > start

6b18579

remove isUpdateFilter

cc5e9f5

Fix highlight roi

5132361

fix color line

124acaf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No.129]Function with the ability to select cells (Data filter B… #536

[No.129]Function with the ability to select cells (Data filter B… #536

sanglevinh commented Dec 23, 2024 •

edited

Loading

milesAraya left a comment •

edited by sanglevinh

Loading

milesAraya Jan 7, 2025

sanglevinh Jan 7, 2025

milesAraya Jan 7, 2025

itutu-tienday Jan 7, 2025

sanglevinh Jan 7, 2025

milesAraya Jan 7, 2025

sanglevinh Jan 7, 2025

milesAraya Jan 7, 2025

milesAraya Jan 7, 2025

sanglevinh Jan 7, 2025

itutu-tienday Jan 7, 2025

itutu-tienday Jan 7, 2025

itutu-tienday Jan 7, 2025

[No.129]Function with the ability to select cells (Data filter B… #536

Are you sure you want to change the base?

[No.129]Function with the ability to select cells (Data filter B… #536

Conversation

sanglevinh commented Dec 23, 2024 • edited Loading

milesAraya left a comment • edited by sanglevinh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanglevinh commented Dec 23, 2024 •

edited

Loading

milesAraya left a comment •

edited by sanglevinh

Loading