[OAS-10368] Grab Agenecy dump on test failures in go-driver #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test containers in host network; Split common functionality into separate script on_failure.sh
jwierzbo
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added agency dump when
DUMP_ON_FAILURE=1to be saved in./arango_data_v$(VERSION)/FAIL_agency_dump-HTTP_VPACK.jsoneg.
DUMP_ON_FAILURE=1 make run-tests-cluster-vpack-no-authMade arangodb_starter start test containers in host network;
--net=hostinstead of running an alpine container to serve that funcitonSeparated all functions that need to be executed when go-driver-test docker container returns any messages (fails) to a separete file
on_failure.shRequirements
jqinstalled on host in order to parse the JSON responses that are received from the database API when creating agency dumps.