Aradhakrishnan gfdl build test #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`environment.yml` had different package reqs than whats in `setup.py` or `meta.yaml`. changed to be consistent. `setup-python` github action gives us accesss to a python with conda in it, remove conda reqs for now. change name.
Ian Laflotte cannot spell.
…te-pip-install-pytest not convinced this will work. lets see.
…da-conda-env-create-pip-install-pytest.yml ian still can't type.
…l to conda-env-create-and-pytest.yml shorter name
remove what seems to be redundant workflow
remove unused workflow
separate steps of docs job by new line for readability
remove unused docker build workflow
remove unused workflow file
create a conda build workflow that doesn't upload anything for PR/MR. change the conda publish workflow to run only upon push to main.
update checkout action to v4, remove conda config line that i'm not sure works and is redundant anyways.
remove branch from meta.yaml
remove gir url from source field in catalogbuilder. messes with conda build call. thank you bennet
include explicit `catalogbuilder.scripts.gen_intake_gfdl` import test in `meta.yaml` for conda package
trying to absorb what create-gfdl-catalog does into conda-env-create-and-pytest to start. if i'm understanding the pipelines correctly, these steps should work with the conda env create approach, and we can re-define them in terms of the pytest suite. lets see if my first attempt here works..
ahhhhh the pytest, conda installations brought in with the python environment pointed to by github actions "setup-python" take precedence over the conda env python etc. not my favorite thing- but it does seem at least to work consistently. i hope to see most steps work after this commit.
`which pytest` upsets github ci/cd... kind of suprising
put publish-conda.yml name field back to old value, to avoid polluting the workflows menu of this repo more than i already did...
that later pytest call isnt redundant, it uses the downloaded artifacts from earlier in the workflow. also, pretty sure the `python` call points to the right one, even if `pytest` doesn't without the path to the executable in the conda env.
remove now-redundant create-gfdl-catalog.yml. we can test all the same things in the pipeline testing the conda env create step. for the future: absorb the test script calls into the pytest suite.
Co-authored-by: Aparna Radhakrishnan <[email protected]>
implementing conda env tricks for github ci/cd i figured out here: NOAA-GFDL/fre-cli#127
now includes files other than `__init__.py` in `catalogbuilder/cats`
…getting put in a conda env's "site-packages" directory. adjust respective workflow file add pytest.ini file for assist pytest calls with finding the tests
… change, and `<root>/intakebuilder/` --> `<root>/catalogbuilder/intakebuilder` change
…-run-pytest.yml change file name / workflow name. change `pip install --prefix` path- shouldn't target `bin/`, but the directory containing it and e.g. `lib` and i.e. other top-level things for the env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.