-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sketch] openat, fsync, and sync #43
base: main
Are you sure you want to change the base?
Conversation
This is close to being mergeable, but still has the global system call design question as #33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🚢
/// | ||
/// - Parameters: | ||
/// - path: The location of the file to open. | ||
/// - at: if `path` is relative, treat it as relative to this file descriptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we should not use prepositions as variable names.
/// - at: if `path` is relative, treat it as relative to this file descriptor | |
/// - base: if `path` is relative, treat it as relative to this file descriptor |
Or we could just call it fd
.
@_alwaysEmitIntoClient | ||
public static func open( | ||
_ path: FilePath, | ||
at: FileDescriptor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at: FileDescriptor, | |
at base: FileDescriptor, |
(etc, throughout this PR.)
I'd be happy with either option! I like |
I much prefer edit: Oh right, that is ignored if the incoming path is absolute. edit 2: The existence of |
No description provided.