-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add beta for testing and npm available #1883
Conversation
@saikrishna321 Could you add https://www.npmjs.com/~kazucocoa to https://www.npmjs.com/package/appium-inspector-plugin project to push If it would be nice to use a different name space as Appium, I'll rename this |
@KazuCocoa Added you! |
Thank you! |
use beta.3 use npm-shrinkwrap.json remove npm-shrinkwrap.json
This reverts commit 662f36c.
@KazuCocoa Tested latest versions and works fine as plugin |
@@ -1,7 +1,7 @@ | |||
import path from 'node:path'; | |||
import {fileURLToPath} from 'node:url'; | |||
|
|||
import {BasePlugin} from 'appium/plugin.js'; | |||
import {BasePlugin} from '@appium/base-plugin'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this way fixed:
[Appium] Could not load plugin 'inspector', so it will not be available. Error in loading the plugin was: Cannot find package 'appium' imported from /Users/kazu/.appium/node_modules/appium-inspector-plugin/index.mjs
[Appium] Error: Cannot find package 'appium' imported from /Users/kazu/.appium/node_modules/appium-inspector-plugin/index.mjs
at packageResolve (node:internal/modules/esm/resolve:854:9)
at moduleResolve (node:internal/modules/esm/resolve:927:18)
at defaultResolve (node:internal/modules/esm/resolve:1169:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:540:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:509:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)
at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40)
at link (node:internal/modules/esm/module_job:95:36)
[Appium] Welcome to Appium v2.14.1 (REV bab86d5de571015b63fd8fc30b47bbe072a1290e)
[Appium] Non-default server args:
error...
appium plugin install --source=npm [email protected]
is only import {BasePlugin} from 'appium/plugin.js';
and peerDependencies
. No "@appium/base-plugin": "^2.3.0"
but appium --use-plugins=inspector--allow-cors
cased error the above.
Latest appium plugin install --source=npm [email protected]
is this current PR's latest.
(I know ideally we'd like to use import {BasePlugin} from 'appium/plugin.js';
only with peerDependencies)
Can the installation steps in the plugin's readme be updated? |
@eglitise ReadMe is here - https://github.com/appium/appium-inspector/tree/main/plugins |
I'm aware; I was referring to the fact that it currently only lists the local installation steps. Since this PR adds the npm installation approach, it should also be added to the readme (and IMO the local installation steps can be removed, since they are objectively more complex for the end user, and belong in the Inspector documentation's Development docs) |
Installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed in the description that the README update will come in another PR - all good then.
Yea, initially, I thought I could put all the planned work in the description in one PR but I'd like to get review and merge only this PR since this was needed to fix |
This PR does:
npm
installFixed
Fixed below as well, but I needed to add
dependencies
...I'll do below as another PR to merge this idea first:
npm
install methodappium-inspector-plugin
packagenpm run build
will build plugin as well