Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable appium-inspector as an appium plugin #1878
feat: enable appium-inspector as an appium plugin #1878
Changes from 57 commits
3ce0cfd
0764820
bc95a0a
f37a521
afa3bf8
9e514c0
5d42e24
1b812da
01a2652
b897b2e
090f50f
d92a944
659d9b7
30c634b
bfdc8e1
5b40a50
a994da9
fb89cf2
231bbc0
3b5fa7d
b9a371b
5469ea3
4c53dab
cb25743
dcf4f63
1c3edc0
86e7006
4d2f828
5248688
a4d14c6
c0934ab
4ed1bd3
9b84563
c67908c
cbb53d0
9f56ed5
b1eb482
972545a
c5fb734
5f5df23
abe014b
33748b8
94ec121
b355207
cb79ed3
3db1202
0ec99fa
fa48100
a42007f
5596c40
0e11407
53fefc4
5916dcc
a2f53a8
8daadd0
352f9a3
f736397
5ea336f
dcaace4
158b537
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be a part of the common
build
script?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to include this in
build
after completing npm publish work as well, so yes but not yet in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this script should be executed automatically as soon as we bump the version of the main project via
npm version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It will be a follow-up PR to treat npm publish stuff in my current plan.