fix: Properly fetch view interaction if it was found under a root #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrubles
reviewed
Oct 13, 2022
| } catch (e: PerformException) { | ||
| // Perform Exception means nothing was found. Return empty list | ||
| emptyList() | ||
| } | ||
| } | ||
| Strategy.VIEWMATCHER -> { | ||
| val matcherJson = selector.toJsonMatcher() | ||
| views = try { | ||
| return try { | ||
| @Suppress("UNCHECKED_CAST") | ||
| getViews(root, matcherJson.query.matcher as Matcher<View>, findOne, matcherJson.query.scope as Matcher<Root>) |
There was a problem hiding this comment.
it is nullable. Does something looks suspicious here?
There was a problem hiding this comment.
If I not mistaken the cast should be Matcher<Root>?, when the scope is null it will throw an Exception
There was a problem hiding this comment.
It should work just fine, as? is needed to do cast from types other than null: https://stackoverflow.com/questions/50836017/safe-cast-vs-cast-to-nullable
KazuCocoa
approved these changes
Oct 14, 2022
KazuCocoa
approved these changes
Oct 14, 2022
|
ok, I'll revert the change. This is anyway an unrelated issue |
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #821 (comment)