Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Naming Convention ValidClassName.NoUpperAcronyms PHPCS #1107

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #1106

@kedarkhaire kedarkhaire added this to the 3.0.11 milestone Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (1e480cf) to head (a899790).
Report is 2 commits behind head on 3.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #1107      +/-   ##
============================================
- Coverage     44.20%   42.97%   -1.23%     
  Complexity     3041     3041              
============================================
  Files           342      342              
  Lines         11110    11110              
============================================
- Hits           4911     4775     -136     
- Misses         6199     6335     +136     

see 22 files with indirect coverage changes

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 777ebfc into apigee:3.x Jan 9, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPCS update on drupal/coder - Drupal.NamingConventions.ValidClassName.NoUpperAcronyms error
2 participants