Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config file path and application bundle parameters and use projec… #99

Closed

Conversation

warrenc5
Copy link

@warrenc5 warrenc5 commented Aug 8, 2018

changed the author and reset the last commit.

@warrenc5
Copy link
Author

google-bot - where art thou?

@ssvaidyanathan
Copy link
Collaborator

@warrenc5 - thanks for the PR
Can you add some description on what this PR is for. I can see the PR title, but would like to know more on what we are adding to the plugin

@warrenc5
Copy link
Author

warrenc5 commented Sep 19, 2018

Hi thanks, for responding, I have tried to make this plugin more compatible with maven project directory structure, specifically able to locate the config.json file within the target dir. We are maven resource filtering the config.json before configuring the bundle. And doing releases which require no changes to files, so we can run mvn clean

@warrenc5
Copy link
Author

warrenc5 commented Oct 8, 2018

actually this solves #93

@warrenc5
Copy link
Author

Hi, we would like to start using this on all our proxies and are waiting for a release.

The main benefit of this patch is.

*Relocatable config.json (i.e sourced from the target directory)
*Enable maven resource filtering of config.json (from the resource directory)
*Allows maven release plugin to work (committing with no modifications to working directory - outside of target directory)

  • Is completely compatible with existing project structures.

Any questions, modifications or documentation required, please let me know.

@ssvaidyanathan
Copy link
Collaborator

Thanks @warrenc5 - can you also include changes to the README file so that I can see what has changed end to end. Update the samples so that we could use that as well for testing the features built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants