Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time range selector moved to shared-ui #3310

Closed

Conversation

Marcelfrueh
Copy link
Contributor

Purpose

Time Range selector used in data explorer is moved to the shared-ui folder. Modules and imports are changed accordingly to maintain functionality. (#3307)

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the ui Anything that affects the UI label Oct 25, 2024
@@ -48,6 +47,7 @@ import { SpDataExplorerRoutes } from '../../data-explorer.routes';
import { DataExplorerRoutingService } from '../../services/data-explorer-routing.service';
import { DataExplorerDetectChangesService } from '../../services/data-explorer-detect-changes.service';
import { SupportsUnsavedChangeDialog } from '../../models/dataview-dashboard.model';
import { TimeSelectionService } from 'projects/streampipes/shared-ui/src/lib/services/time-selection.service';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import should be @streampipes/shared-ui

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 28, 2024
Copy link
Contributor

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

@github-actions github-actions bot added the stale Marks pull requests that are classified as `stale` by our bot. label Nov 27, 2024
@Marcelfrueh Marcelfrueh deleted the time-range-selector-restructure branch December 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file stale Marks pull requests that are classified as `stale` by our bot. ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants