Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9128] Fix NPE when gRPC client ack message immediately after changing proxy #9129

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

qianye1001
Copy link
Contributor

…changing proxy

Which Issue(s) This PR Fixes

Fixes #9128

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.93%. Comparing base (f6249e5) to head (11bd640).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...tmq/proxy/grpc/v2/consumer/AckMessageActivity.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9129      +/-   ##
=============================================
- Coverage      48.02%   47.93%   -0.09%     
- Complexity     12050    12055       +5     
=============================================
  Files           1320     1321       +1     
  Lines          92846    93024     +178     
  Branches       11898    11926      +28     
=============================================
+ Hits           44588    44594       +6     
- Misses         42748    42922     +174     
+ Partials        5510     5508       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 7bcf919 into apache:develop Jan 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ack may cause NPE when grpc client change proxy
3 participants