Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #7552] Fix local mode by making ext-headers remoting protocol compliant #7549

Closed
wants to merge 1 commit into from
Closed

[ISSUE #7552] Fix local mode by making ext-headers remoting protocol compliant #7549

wants to merge 1 commit into from

Conversation

lizhanhui
Copy link
Contributor

@lizhanhui lizhanhui commented Nov 10, 2023 •
edited
Loading

fix #7552

fixed LocalGrpcIT

@lizhanhui lizhanhui requested a review from xdkxlk November 10, 2023 09:19
@lizhanhui lizhanhui changed the title fix local mode by making ext-headers remoting protocol compliant [ISSUE #7552] Fix local mode by making ext-headers remoting protocol compliant Nov 10, 2023
@lizhanhui lizhanhui requested a review from fuyou001 November 10, 2023 09:50
joeCarf
joeCarf approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joeCarf
joeCarf reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that this pr can be closed now

@drpmma
Copy link
Contributor

drpmma commented Nov 13, 2023

LGTM

@lizhanhui
Copy link
Contributor Author

seems that this pr can be closed now

@lizhanhui lizhanhui closed this Nov 13, 2023
@lizhanhui lizhanhui deleted the fix_local_mode branch November 13, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeCarf joeCarf joeCarf approved these changes

@xdkxlk xdkxlk Awaiting requested review from xdkxlk

@fuyou001 fuyou001 Awaiting requested review from fuyou001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Local Mode cannot work properly without necessary remoting ext-headers accessible
3 participants
@lizhanhui @drpmma @joeCarf