[ISSUE #7509] Optimize updateTopicRouteInfoFromNameServer #7510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Throw MQClientException for updateTopicRouteInfoFromNameServer * Add compatible updateTopicRouteInfoFromNameServerWithoutException method
joeCarf
reviewed
Oct 28, 2023
| @@ -785,6 +793,7 @@ public boolean updateTopicRouteInfoFromNameServer(final String topic, boolean is | |||
| if (!topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) && !topic.equals(TopicValidator.AUTO_CREATE_TOPIC_KEY_TOPIC)) { | |||
| log.warn("updateTopicRouteInfoFromNameServer Exception", e); | |||
| } | |||
| throw e; | |||
There was a problem hiding this comment.
先log再throw的写法可能会造成上层出现重复打印error的情况
There was a problem hiding this comment.
这里是为了尽可能和之前的行为保持一致，如果去掉的话，可能会导致原先打印的日志无法被打印出来。
Codecov Report
@@ Coverage Diff @@
## develop #7510 +/- ##
==========================================
Coverage 43.01% 43.01%
+ Complexity 9685 9683 -2
==========================================
Files 1158 1158
Lines 83977 83981 +4
Branches 10915 10915
==========================================
+ Hits 36122 36124 +2
- Misses 43362 43363 +1
- Partials 4493 4494 +1
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
To throw the specific exception to the upper level with more information.
Fixes #7509
Brief Description
Throw MQClientException for updateTopicRouteInfoFromNameServer
Add compatible updateTopicRouteInfoFromNameServerWithoutException method
How Did You Test This Change?