Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7489] Code comment enhancement in example #7490

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

joeCarf
Copy link
Contributor

@joeCarf joeCarf commented Oct 23, 2023

Which Issue(s) This PR Fixes

Fixes #7489

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #7490 (d9cf5e7) into develop (f0f15b5) will increase coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #7490      +/-   ##
=============================================
+ Coverage      42.93%   42.94%   +0.01%     
- Complexity      9660     9670      +10     
=============================================
  Files           1161     1161              
  Lines          83930    83933       +3     
  Branches       10898    10898              
=============================================
+ Hits           36038    36049      +11     
+ Misses         43410    43407       -3     
+ Partials        4482     4477       -5     
Files Coverage Δ
...tmq/proxy/service/message/LocalMessageService.java 60.81% <100.00%> (ø)
...mq/proxy/service/message/LocalRemotingCommand.java 88.88% <100.00%> (+1.38%) ⬆️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.37% <0.00%> (ø)
...pache/rocketmq/remoting/protocol/LanguageCode.java 87.50% <50.00%> (-3.41%) ⬇️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joeCarf
Copy link
Contributor Author

joeCarf commented Oct 23, 2023

@RongtongJin hi~ PTAL

@RongtongJin RongtongJin merged commit 8f020b3 into apache:develop Oct 23, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code comments of updateConsumeOffset() should be corrected
4 participants