[ISSUE #7437] Add the CRC check of commitlog #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joeCarf
reviewed
Oct 21, 2023
| @@ -61,7 +61,6 @@ | |||
| import org.apache.rocketmq.store.logfile.MappedFile; | |||
| import org.apache.rocketmq.store.util.LibC; | |||
| import org.rocksdb.RocksDBException; | |||
|
|
|||
There was a problem hiding this comment.
maybe no need to reformat the import in this file and MessageConfig.java
done |
added 2 commits
October 25, 2023 10:34
Codecov Report
@@ Coverage Diff @@
## develop #7468 +/- ##
=============================================
- Coverage 43.03% 43.02% -0.01%
- Complexity 9672 9681 +9
=============================================
Files 1158 1158
Lines 83858 83978 +120
Branches 10889 10915 +26
=============================================
+ Hits 36090 36135 +45
- Misses 43307 43351 +44
- Partials 4461 4492 +31
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7437
Brief Description
How Did You Test This Change?