-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tiered store README.md error about Configuration #7436
Fix tiered store README.md error about Configuration #7436
Conversation
@ShadowySpirits Hi, I am trying to use tiered store. Thanks for your work. PTAL |
I prefer |
I can accept both org.apache.rocketmq.tieredstore.common.TieredMessageStoreConfig#tieredStoreFilePath |
@golden-yang I suggest to modify the code. |
I change tieredStoreFilePath to tieredStoreFilepath. @ShadowySpirits PTAL |
@zhouxinyu Please approve the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a117919
to
371b765
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7436 +/- ##
=============================================
+ Coverage 42.97% 43.06% +0.08%
- Complexity 9665 9686 +21
=============================================
Files 1161 1161
Lines 83920 83926 +6
Branches 10898 10899 +1
=============================================
+ Hits 36064 36139 +75
+ Misses 43379 43314 -65
+ Partials 4477 4473 -4
... and 28 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There is a widely use of filePath in the rocketmq project. The rename operation which not only brings compatibility issues but also conflicts with the naming style of the rocketmq project. It is recommended to revert this change. |
…nfiguration (apache#7436)" This reverts commit 70dc93a.
Which Issue(s) This PR Fixes
ISSUE #5923 add README.md file to explain how to use tiered storage.
There was a simple configuration error