Optimize ConsumeMessageOrderlyService enumerated types of comparison #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized performance
fqgsoftwareengineer
changed the title
joeCarf
reviewed
Oct 9, 2023
| @@ -86,7 +86,7 @@ public ConsumeMessageOrderlyService(DefaultMQPushConsumerImpl defaultMQPushConsu | |||
| } | |||
|
|
|||
| public void start() { | |||
| if (MessageModel.CLUSTERING.equals(ConsumeMessageOrderlyService.this.defaultMQPushConsumerImpl.messageModel())) { | |||
| if (MessageModel.CLUSTERING==ConsumeMessageOrderlyService.this.defaultMQPushConsumerImpl.messageModel()) { | |||
There was a problem hiding this comment.
need blank space around the equal operator
There was a problem hiding this comment.
Space formatting has been added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized performance
Which Issue(s) This PR Fixes
Optimized performance：
The equals of enumeration types can be replaced by ==, which improves performance and is safer at compile and run time.
see:
Brief Description
How Did You Test This Change?
Just compare the pressure measurements with the previous ones