[ISSUE #6873] Not update controller address list when the resolved result is empty

[weihubeats]

#6873

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.90%. Comparing base (1b42515) to head (9eb378e).

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #6874   +/-   ##
==========================================
  Coverage      42.90%   42.90%           
+ Complexity     10370    10368    -2     
==========================================
  Files           1270     1270           
  Lines          88721    88721           
  Branches       11405    11405           
==========================================
+ Hits           38062    38070    +8     
+ Misses         45954    45946    -8     
  Partials        4705     4705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheR1sing3un]

LGTM~

[xdkxlk]

I think we should differentiate between whether it throws an exception or actually returns null. And dnsLookupAddressByDomain is also used by updateNameServerAddressListByDnsLookup in BrokerOuterAPI .

[weihubeats]

I think even if the actual is null, it should not be updated to null, because the actual is null is also abnormal.
Exceptions or actual null can be distinguished by logging

[RongtongJin]

If the parsing fails, it should be printed in the log. What are the benefits of setting it to null here?

[weihubeats]

I don't understand what you mean, here is the parsing failure will return null, so if it is null then it is not updated. The advantage of this is that if the dns exception will not replace the normal address of the controller with null

[ferrirW]

If parsing fails, the api will return the empty list, not null

you refered case can be provide more information for repetition ？