Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6205] Asynchronize DefaultPullConsumer pull method #6341

Closed
wants to merge 2 commits into from

Conversation

miles-ton
Copy link
Contributor

@miles-ton miles-ton commented Mar 14, 2023

Make sure set the target branch to develop

What is the purpose of the change

close #6205

I think it's not necessary to open multiple threads to synchronizely pull message to local, and causing we are using LinkBlockingQueue to asynchronizely consume local message, we can completely pull message from remote broker to local in background instead of synchronized pull. so I removed pull() and added a pullAsync()

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

I think it's not necessary to open multiple threads to synchronizely pull message to local, and causing we are using LinkBlockingQueue to asynchronizely consume local message, we can completely pull message from remote broker to local in background instead of synchronized pull. so I removed pull() and added a pullAsync()
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql_analysis.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #6341 (e5d0c08) into develop (46962c2) will increase coverage by 0.10%.
The diff coverage is 48.00%.

@@              Coverage Diff              @@
##             develop    #6341      +/-   ##
=============================================
+ Coverage      42.97%   43.07%   +0.10%     
- Complexity      9677     9697      +20     
=============================================
  Files           1158     1158              
  Lines          83987    83995       +8     
  Branches       10917    10918       +1     
=============================================
+ Hits           36093    36183      +90     
+ Misses         43399    43318      -81     
+ Partials        4495     4494       -1     
Files Coverage Δ
...ketmq/client/consumer/DefaultLitePullConsumer.java 74.86% <100.00%> (ø)
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.32% <45.83%> (-0.22%) ⬇️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@miles-ton miles-ton closed this May 14, 2024
@miles-ton miles-ton deleted the issue#6205 branch May 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LitePullConsumer support async pull message
2 participants