PARQUET-2422: Prevent unwrapping of Hadoop filestreams

[rathinb-db]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Parquet Jira issues and references
  them in the PR title. For example, "PARQUET-1234: My Parquet PR"
  • https://issues.apache.org/jira/browse/PARQUET-2422
  • In case you are adding a dependency, check if the license complies with
    the ASF 3rd Party License Policy.

Refactor Hadoop filestreams to prevent filestream unwrapping (and keeping the original filestream type).

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Tests not necessary since this is a refactor.

Commits

• My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
  from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Style

• My contribution adheres to the code style guidelines and Spotless passes.
  • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

[wgtmac]

Could you please create a JIRA?

[wgtmac]

It looks trivial to me. Thanks!

It would be good if @steveloughran @Fokko can double check as I'm not that familiar with its history.

[steveloughran]

Not sure why there's a need to return a function rather than do the work -is there some other code which needs this?

In an ideal world parquet would be hadoop 3.3+ only and life would be simpler, not just here but with openFile(), ByteBufferPositionedReadable and more

[wgtmac]

@shangxinli @gszadovszky @ConeyLiu Do you have any comment?

[gszadovszky]

It looks good to me.

[ConeyLiu]

Documentation should also be updated

[wgtmac]

@rathinb-db Could you resolve this comment? Thanks!

[ConeyLiu]

+1, just left a minor comment about doc.