Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2419: Reduce noisy logging when running test suite #1253

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

amousavigourabi
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Only introduces changes to CI/CD workflows

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

pom.xml Outdated
@@ -716,8 +718,13 @@
<!-- Profile for CI tests to have less output -->
<profile>
<id>ci-test</id>
<activation>
<property>
<name>ci-test-profile</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why enable it by default? BTW, do the surefire.xx arguments actually work locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, when you run mvn test you do not need the immense amount of low level logs provided now. It makes more sense for them to be opt-in. As for the other question, luckily these settings do work locally.

@amousavigourabi amousavigourabi force-pushed the reduce-noisy-test-logging branch from 8c7d013 to abbc286 Compare January 14, 2024 13:18
@wgtmac
Copy link
Member

wgtmac commented Jan 14, 2024

cc @Fokko

<profile>
<id>ci-test</id>
<id>verbose-test</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about keeping the ci-test profile to be verbose as is, and add a new compact one which is activated by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now our output is verbose by default, with the ci-test profile being more compact. I tried looking into enabling ci-test by default, but when a profile is activeByDefault, it gets deactivated whenever another profile becomes active. The problem then is that parquet-mr has a few profiles that get activated automatically depending on the environment Maven is run in, so we cannot rely on it in that way. Because of this, the PR gets rid of the slimmed down ci-test profile and replaces it with a verbose one, such that the (currently default) verbose output becomes opt-in, with the more lean output just being the default setting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@gszadovszky @shangxinli Do you have different opinions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think verbose-test is a better name than ci-test

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookg good, thanks @amousavigourabi for working on this 👍

<profile>
<id>ci-test</id>
<id>verbose-test</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think verbose-test is a better name than ci-test

@wgtmac wgtmac merged commit ed308ff into apache:master Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants