Bump Elephantbird

[Fokko]

Not sure if we just should remove it (that would break quite a few APIs, probably something for Parquet 2.0), or update it like this PR. It uses an ancient version:

4.4  -> Thrift 0.7.0 😱
4.17 -> Thrift 0.10.0

>4.4 makes a lot of test helpers private, so I had to remove a few tests.

Make sure you have checked all steps below.

Jira

• My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
  • https://issues.apache.org/jira/browse/PARQUET-XXX
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

[wgtmac]

Does an old version of elephantbird prohibit us from upgrading thrift in the future? Even the latest 4.17 is pretty old. Removing these tests may add more risk to break things though I'm not sure whether these modules are still actively used.

[Fokko]

It blocks the upgrade. Somewhere in a static block an exception is being thrown.

Removing these tests may add more risk to break things though I'm not sure whether these modules are still actively used.

The artifact is littered with CVE's, so I hope no-one is using this still.

apache-thrift does not seem to be used anymore (usages of 0 since 1.12.2):

apache-protobuf does have some usage:

So we can leave that in for now. Let me prepare a PR and also sent out an email on the dev-list.

[Fokko]

I don't think this is a feasible option, let me close it