Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2274: Remove Yetus #1056

Merged
merged 3 commits into from
Nov 8, 2023
Merged

PARQUET-2274: Remove Yetus #1056

merged 3 commits into from
Nov 8, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 13, 2023

I don't think this is used anywhere anymore.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

I don't think this is used anywhere anymore.
@Fokko Fokko force-pushed the fd-remove-yetus branch from 6ab7d6b to 7525f22 Compare April 13, 2023 19:58
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I am not familiar with this tool.

cc @gszadovszky

@gszadovszky
Copy link
Contributor

We started to use this to mark somehow the public classes/methods that did not ment to be public for the API users but only because of our current module layout. Since we are on java8 we do not have anything else to mark them. But because we do not have any tools running on the API (not even talking about the client side) it does not really make sense to have these annotations. Maybe it would worth some comments as replacements of the annotations but I am not sure they would be checked before used.

@shangxinli
Copy link
Contributor

Yeah, adding some comments could help although sometimes people ignore it. But some of them are already used by other tool like the columnIndex one.

@shangxinli
Copy link
Contributor

@Fokko Do you think you can add some comment and we merge this PR in?

@Fokko
Copy link
Contributor Author

Fokko commented Oct 17, 2023

@shangxinli Sorry for the long wait, I've added the comments 👍

@wgtmac
Copy link
Member

wgtmac commented Oct 18, 2023

@sekikn Do you have any comment?

@sekikn
Copy link
Contributor

sekikn commented Oct 18, 2023

No, I agree with replacing audience annotations with appropriate comments for now, since we don't have a tool for enforcing restriction based on the annotations, as mentioned by @gszadovszky.

@Fokko
Copy link
Contributor Author

Fokko commented Nov 8, 2023

Thank you @sekikn for confirming. I'll move this forward.

@Fokko Fokko merged commit 56f40e4 into apache:master Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants