PARQUET-2420 : ThriftParquetWriter Convert byte to LogicalType int32 …

…bitWidth 8 instead of primitive int32 (#1254)
apache · Jan 19, 2024 · d03b49b · d03b49b
1 parent c82d5b4
commit d03b49b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
@@ -362,7 +362,7 @@ public ConvertedField visit(BoolType boolType, State state) {
 
   @Override
   public ConvertedField visit(ByteType byteType, State state) {
-    return visitPrimitiveType(INT32, state);
+    return visitPrimitiveType(INT32, LogicalTypeAnnotation.intType(8, true), state);
   }
 
   @Override

diff --git a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestThriftSchemaConverter.java b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestThriftSchemaConverter.java
@@ -376,7 +376,9 @@ public void testToThriftType() throws Exception {
 
   @Test
   public void testLogicalTypeConvertion() throws Exception {
-    String expected = "message ParquetSchema {\n" + "  required int32 test_i16 (INTEGER(16,true)) = 1;" + "}";
+    String expected = "message ParquetSchema {\n" + "  required int32 test_i16 (INTEGER(16,true)) = 1;\n"
+        + "  required int32 test_i8 (INTEGER(8,true)) = 2;\n"
+        + "}\n";
     ThriftSchemaConverter schemaConverter = new ThriftSchemaConverter();
     final MessageType converted = schemaConverter.convert(TestLogicalType.class);
     assertEquals(MessageTypeParser.parseMessageType(expected), converted);

diff --git a/parquet-thrift/src/test/thrift/test.thrift b/parquet-thrift/src/test/thrift/test.thrift
@@ -97,5 +97,6 @@ struct StructWithExtraField {
 }
 
 struct TestLogicalType {
-  1: required i16 test_i16
+  1: required i16 test_i16,
+  2: required byte test_i8
 }