-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PARQUET-2374: Add metrics support for parquet file reader (#1187)
- Loading branch information
1 parent
8418b8b
commit 2e0cd19
Showing
6 changed files
with
194 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReaderMetrics.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.parquet.hadoop; | ||
|
||
public enum ParquetFileReaderMetrics { | ||
|
||
// metrics | ||
ReadTime("time spent in reading Parquet file from storage"), | ||
SeekTime("time spent in seek when reading Parquet file from storage"), | ||
ReadSize("read size when reading Parquet file from storage (MB)"), | ||
ReadThroughput("read throughput when reading Parquet file from storage (MB/sec)"), | ||
DecompressTime("time spent in block decompression"), | ||
DecompressSize("decompressed data size (MB)"), | ||
DecompressThroughput("block decompression throughput (MB/sec)"); | ||
|
||
private final String desc; | ||
|
||
ParquetFileReaderMetrics(String desc) { | ||
this.desc = desc; | ||
} | ||
|
||
public String description() { | ||
return desc; | ||
} | ||
} |
46 changes: 46 additions & 0 deletions
46
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetMetricsCallback.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.parquet.hadoop; | ||
|
||
import org.apache.hadoop.classification.InterfaceStability; | ||
|
||
/** | ||
* A simple interface to pass basic metric values by name to any implementation. Typically, an | ||
* implementation of this interface will serve as a bridge to pass metric values on | ||
* to the metrics system of a distributed engine (hadoop, spark, etc). | ||
* <br> | ||
* Development Note: This interface should provide a default implementation for any new metric tracker | ||
* added to allow for backward compatibility | ||
* <br> | ||
* e.g. | ||
* <br> | ||
* <code>default addMaximum(key, value) { } ; </code> | ||
*/ | ||
@InterfaceStability.Unstable | ||
public interface ParquetMetricsCallback { | ||
void setValueInt(String name, int value); | ||
|
||
void setValueLong(String name, long value); | ||
|
||
void setValueFloat(String name, float value); | ||
|
||
void setValueDouble(String name, double value); | ||
|
||
void setDuration(String name, long value); | ||
} |