Kafka Connect: Add SMTs for Debezium and AWS DMS #11936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailsimsek
commented
Jan 9, 2025
| dependencies { | ||
| implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow') | ||
| implementation libs.bson | ||
| // implementation libs.slf4j //TODO DISABLED! do we need this?? |
There was a problem hiding this comment.
commented out this. not sure if its needed?
ismailsimsek
commented
Jan 9, 2025
| @@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') { | |||
|
|
|||
| assemble.dependsOn distZip, hiveDistZip | |||
| } | |||
|
|
|||
| project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') { | |||
There was a problem hiding this comment.
Question, what is the recommended way to keep the commit history or previous committers? using co author feature?
as is git history and previous commiters are not copied over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10844
resolves #11914
Copied over kafka-connect-transforms code. no code changes made
applied code formatting
and updated build.gradle accordingly
cc: @bryanck could you please take look at this when you have chance?