Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1.x]: Upgrade helm procedure test #4947

Conversation

gansheer
Copy link
Contributor

Backport fix #4927

Release Note

fix: Helm upgrade procedure with CRD management

@gansheer gansheer force-pushed the fix/4923_helm_upgrade_procedure_cp_2.1.x branch from df3d6b3 to 8d3a979 Compare November 30, 2023 14:55
@gansheer gansheer marked this pull request as ready for review November 30, 2023 14:56
@gansheer
Copy link
Contributor Author

@squakez is it normal to not have the 2.1.0 chart here https://github.com/apache/camel-k/tree/release-2.1.x/docs/charts ? If not I can cherry-pick it as well.

@squakez
Copy link
Contributor

squakez commented Nov 30, 2023

@squakez is it normal to not have the 2.1.0 chart here https://github.com/apache/camel-k/tree/release-2.1.x/docs/charts ? If not I can cherry-pick it as well.

Yes. Charts are only provided on main branch.

@gansheer
Copy link
Contributor Author

gansheer commented Dec 1, 2023

@squakez is it normal to not have the 2.1.0 chart here https://github.com/apache/camel-k/tree/release-2.1.x/docs/charts ? If not I can cherry-pick it as well.

Yes. Charts are only provided on main branch.

Ok, then I am setting it back to draft to add some condition in the test.

@gansheer gansheer marked this pull request as draft December 1, 2023 07:55
@gansheer gansheer marked this pull request as ready for review December 5, 2023 09:22
@gansheer
Copy link
Contributor Author

gansheer commented Dec 5, 2023

@squakez @oscerd can you launch the falling test suite please 🙏 ?

@squakez
Copy link
Contributor

squakez commented Dec 5, 2023

@squakez @oscerd can you launch the falling test suite please 🙏 ?

We have many builds on going in parallel. I'll launch this again once there is less traffic.

@gansheer
Copy link
Contributor Author

gansheer commented Dec 5, 2023

We have many builds on going in parallel. I'll launch this again once there is less traffic.

Yes, I saw, no worries. It was to give you the priority of rerun for my opened PRs 😅

@gansheer
Copy link
Contributor Author

gansheer commented Dec 5, 2023

@squakez It don't know what to make of the test failures. I can remove the helm upgrade e2e test if needed to ensure it is not the source of the failures or you can merge as it is. WDYT ?

@squakez
Copy link
Contributor

squakez commented Dec 5, 2023

Running checks is cheap, let's make sure all is green. No rush to have it merged.

@squakez squakez merged commit 279b8ce into apache:release-2.1.x Dec 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants