Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(knative): make installation explicit #4873

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Oct 27, 2023

Instead of letting the CLI perfom the installation, we need to make it explicit in order to use the same approach for any other installation methodology.

Closes #4716

Release Note

feat(knative): make installation explicit

@squakez squakez force-pushed the feat/4716 branch 2 times, most recently from 1f615b4 to 82ac209 Compare October 27, 2023 10:32
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

2 similar comments
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@squakez squakez linked an issue Oct 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@squakez squakez marked this pull request as ready for review November 7, 2023 10:07
Copy link
Contributor

github-actions bot commented Nov 7, 2023

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

Copy link
Contributor

github-actions bot commented Nov 7, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

Copy link
Contributor

github-actions bot commented Nov 7, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

Copy link
Contributor

github-actions bot commented Nov 8, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@squakez squakez force-pushed the feat/4716 branch 2 times, most recently from b9d9487 to a8c8fea Compare November 10, 2023 09:38
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

1 similar comment
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@squakez squakez force-pushed the feat/4716 branch 2 times, most recently from 9f69d4e to 7af05e8 Compare December 12, 2023 10:41
@squakez squakez force-pushed the feat/4716 branch 3 times, most recently from b9b5298 to 77b8e0e Compare December 20, 2023 15:20
Copy link
Contributor

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@squakez squakez force-pushed the feat/4716 branch 5 times, most recently from 7a11dda to cbe33d4 Compare December 20, 2023 17:19
@squakez squakez marked this pull request as draft December 20, 2023 17:19
@squakez squakez force-pushed the feat/4716 branch 3 times, most recently from 1785626 to 69c026a Compare December 21, 2023 15:30
@squakez squakez marked this pull request as ready for review December 21, 2023 15:30
@squakez squakez force-pushed the feat/4716 branch 6 times, most recently from e866723 to 2501beb Compare December 22, 2023 14:47
* The resources required to watch Knative are created for all installation methodologies
* A log message is shown in the operator to verify if it has the privileges to watch Knative
* Documentation

Closes apache#4716
Copy link
Contributor

github-actions bot commented Jan 2, 2024

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%)

@squakez squakez merged commit c8e93fc into apache:main Jan 2, 2024
15 of 16 checks passed
@squakez squakez deleted the feat/4716 branch January 2, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative installation procedure Helm installation procedure does not support Knative
3 participants