Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): add root image info #4836

Merged
merged 2 commits into from
Oct 20, 2023
Merged

feat(build): add root image info #4836

merged 2 commits into from
Oct 20, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Oct 19, 2023 •
edited
Loading

With this PR we set the root image from which an incremental kit has started. We use this information to select properly the kit to inherit, making sure we start a new hierarchy if the base image has changed.

The base image can be easily now be overridden using builder.base-image trait property.

This would be the result making changes to the base image on the fly.

k get ik
NAME                       ALIAS   PHASE   TYPE       LAYOUT     IMAGE                                                                                                                          ROOT
kit-ckofr2pbtegs738g3mog           Ready   platform   fast-jar   10.102.33.4/default/camel-k-kit-ckofr2pbtegs738g3mog@sha256:bab614cad6e0daa2e803fe9cbf7c890ef3481b00437d69cd631c4e5914dcc7e0   eclipse-temurin:17
kit-ckofrf9btegs738g3mp0           Ready   platform   fast-jar   10.102.33.4/default/camel-k-kit-ckofrf9btegs738g3mp0@sha256:8a7f369fe9de0875d2c67cd308e626ca56a32e001802cbf79a110fa80a985a14   eclipse-temurin:17
kit-ckofse1btegs738g3mqg           Ready   platform   fast-jar   10.102.33.4/default/camel-k-kit-ckofse1btegs738g3mqg@sha256:fd2dd9819e314684e80086acd7aff8f390bbf9835c2ea2a36ad4c8dccfea44c8   registry.access.redhat.com/ubi8/openjdk-17:1.16
kit-ckofsq1btegs738g3mr0           Ready   platform   fast-jar   10.102.33.4/default/camel-k-kit-ckofsq1btegs738g3mr0@sha256:36ce55be64a6d555aafb79f0df7a25f062aeea136f9cdac2cbe23a0fa4851a90   registry.access.redhat.com/ubi8/openjdk-17:1.16
kit-ckoh539btegs738g3mu0           Ready   platform   fast-jar   10.102.33.4/default/camel-k-kit-ckoh539btegs738g3mu0@sha256:c68d1b8a1fb1e9935a63ef28ae62970da51b74183099d991d21776d8c544dc8d   eclipse-temurin:17.0.8.1_1-jdk-ubi9-minimal
  • Useful to know from which image a kit hierarchy started
  • added builder.base-image property trait to override easily the base image

Ref #2844

Release Note

feat(build): add root image info

@squakez squakez added the kind/feature New feature or request label Oct 19, 2023
@squakez squakez force-pushed the feat/root_kit_image branch from 6159f9d to cc9c4c4 Compare October 19, 2023 11:34
@squakez squakez force-pushed the feat/root_kit_image branch from cc9c4c4 to f73f252 Compare October 19, 2023 11:40
@squakez
feat(build): add root image info
aab98b4 
* Useful to know from which image a kit hierarchy started
* added builder.base-image property trait to override easily the base image

Ref apache#2844
@squakez squakez force-pushed the feat/root_kit_image branch from f73f252 to aab98b4 Compare October 19, 2023 14:53
@squakez
Copy link
Contributor Author

squakez commented Oct 20, 2023

Checks failure unrelated

@squakez squakez merged commit 9436c6b into apache:main Oct 20, 2023
15 of 16 checks passed
@squakez squakez deleted the feat/root_kit_image branch October 20, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gansheer gansheer gansheer approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squakez @oscerd @gansheer