-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Ed25519 polyfill now accepts the full range of algorithm identifiers for the Ed25519
curve
#59
Open
steveluscher
wants to merge
1
commit into
main
Choose a base branch
from
01-13-the_ed25519_polyfill_now_accepts_the_full_range_of_algorithm_identifiers_for_the_ed25519_curve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+254
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5405f81 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (3)
Unchanged files (124)
Total files change +265B +0.08% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
01-13-the_ed25519_polyfill_now_accepts_the_full_range_of_algorithm_identifiers_for_the_ed25519_curve
branch
from
January 13, 2025 20:39
42cb142
to
5405f81
Compare
jordaaash
reviewed
Jan 13, 2025
packages/webcrypto-ed25519-polyfill/src/__tests__/install-test.ts
Outdated
Show resolved
Hide resolved
…ers for the `Ed25519` curve
steveluscher
force-pushed
the
01-13-the_ed25519_polyfill_now_accepts_the_full_range_of_algorithm_identifiers_for_the_ed25519_curve
branch
from
January 14, 2025 02:42
5405f81
to
a6be9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The string
Ed25519
is not the only valid algorithm identifier for the Edwards curve. We need to support all of the other forms it could take.Summary of Changes
Support both the string and the object form of the Ed25519 algorithm identifier, case insensitive.