reworks blockstore ColumnIndexDeprecation trait #4460
+35
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
changed the title
behzadnouri
force-pushed
the
bs-column-depr-key
branch
2 times, most recently
from
6f8b9c9 to
eb7aedb
Compare
Similar to
anza-xyz#4416
in order to add more type-safety and avoid unnecessary heap allocations:
https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L932
https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L1005
https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L1075
the commit removes
const DEPRECATED_INDEX_LEN: usize;
from ColumnIndexDeprecation trait and instead adds:
type DeprecatedKey: AsRef<[u8]>;
behzadnouri
force-pushed
the
bs-column-depr-key
branch
from
eb7aedb to
9144400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unnecessary heap allocations in
ColumnIndexDeprecationimplementations:https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L932
https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L1005
https://github.com/anza-xyz/agave/blob/8a0c9b461/ledger/src/blockstore_db.rs#L1075
Summary of Changes
Similar to #4416 in order to add more type-safety and avoid unnecessary heap allocations the commit removes
from
ColumnIndexDeprecationtrait and instead adds: