Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server_to_ansys_version #2013

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Fix server_to_ansys_version #2013

merged 5 commits into from
Jan 14, 2025

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jan 13, 2025

Realized the current implementation of the ServerToAnsysVersion map would not give the right answer for 10.0 (it gives 10R0).
Fixed this and refactored to not need to update this version map anymore for each new version.

The only requirement is for DPF to continue only bumping major for new Ansys releases.

@PProfizi PProfizi added the bug Something isn't working label Jan 13, 2025
@PProfizi PProfizi added this to the 0.13.4 milestone Jan 13, 2025
@PProfizi PProfizi self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (c2e57d6) to head (8312868).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   88.46%   88.40%   -0.07%     
==========================================
  Files          89       89              
  Lines       10261    10268       +7     
==========================================
  Hits         9077     9077              
- Misses       1184     1191       +7     

tests/test_version.py Show resolved Hide resolved
src/ansys/dpf/core/_version.py Outdated Show resolved Hide resolved
src/ansys/dpf/core/_version.py Outdated Show resolved Hide resolved
@PProfizi PProfizi requested a review from BClappe January 14, 2025 08:06
@rafacanton rafacanton self-requested a review January 14, 2025 08:35
@PProfizi PProfizi merged commit a1bfa92 into master Jan 14, 2025
46 checks passed
@PProfizi PProfizi deleted the fix/server_to_ansys_version branch January 14, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants