Deprecate pkg_resources usage #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
- Coverage 88.44% 88.44% -0.01%
==========================================
Files 89 89
Lines 10252 10260 +8
==========================================
+ Hits 9067 9074 +7
- Misses 1185 1186 +1 |
rafacanton
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pkg_resourceslibrary is marked as deprecated and raises warnings.We switch to using
importlib.This is done is two places:
ansys.dpf.core.__init__.pyto check the presence ofansys-dpf-gate,ansys-dpf-gatebinoransys-grpc-dpfin the Python environment and raise a deprecation error.ansys.dpf.gate.load_api.__paths_to_dpf_server_library_installsto detect installedansys-dpf-server***libraries and return install paths.