Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix averaging example plots #1988

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jan 3, 2025

The first example of the averaging section lost its calls to plot methods at some point, not fitting the description anymore. This PR adds them back to fix the example.

The first example of the averaging section lost its calls to plot methods at some point, not fitting the description anymore. This PR adds them back to fix the example.
@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Jan 3, 2025
@PProfizi PProfizi requested a review from moe-ad January 3, 2025 15:41
@PProfizi PProfizi self-assigned this Jan 3, 2025
@PProfizi
Copy link
Contributor Author

PProfizi commented Jan 3, 2025

Hi @moe-ad, your PR #1953 made me realize there is an issue with the example where plots were no longer generated.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (b7f89f7) to head (984aef9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
+ Coverage   88.41%   88.44%   +0.02%     
==========================================
  Files          89       89              
  Lines       10258    10251       -7     
==========================================
- Hits         9070     9066       -4     
+ Misses       1188     1185       -3     

Copy link
Contributor

@moe-ad moe-ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moe-ad moe-ad merged commit ff8e662 into master Jan 6, 2025
46 checks passed
@moe-ad moe-ad deleted the examples/fix_00-compute_and_average_plots branch January 6, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants