Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: find and fix edge methods #1672

Open
wants to merge 17 commits into
base: blitz
Choose a base branch
from
Open

feat: find and fix edge methods #1672

wants to merge 17 commits into from

Conversation

mlkaplan36
Copy link

Description

find and fix edge methods (split, extra, short)

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@mlkaplan36 mlkaplan36 self-assigned this Jan 21, 2025
@mlkaplan36 mlkaplan36 requested a review from a team as a code owner January 21, 2025 18:31
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 21, 2025
@mlkaplan36 mlkaplan36 enabled auto-merge (squash) January 21, 2025 21:00
mlkaplan36 and others added 4 commits January 21, 2025 14:25
@mlkaplan36
Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…
7d84a0d 
…o feat/find_and_fix_edge_methods

# Conflicts:
#	src/ansys/geometry/core/tools/repair_tools.py
@mlkaplan36
Merge branch 'feat/find_and_fix_edge_methods' of https://github.com/a…
215869c 
…nsys/pyansys-geometry into feat/find_and_fix_edge_methods

# Conflicts:
#	src/ansys/geometry/core/tools/repair_tools.py
@pre-commit-ci
chore: auto fixes from pre-commit hooks
010013c
@RobPasMue
fix: tab issues
36d8cfe
RobPasMue
RobPasMue requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - let's address them. Thanks @mlkaplan36

src/ansys/geometry/core/tools/repair_tools.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/tools/repair_tools.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/tools/repair_tools.py Show resolved Hide resolved
mlkaplan36 and others added 9 commits January 22, 2025 07:25
RobPasMue
RobPasMue approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some testing would be great though! Other than that - LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jonahrb jonahrb Awaiting requested review from jonahrb

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

@umutsoysalansys umutsoysalansys Awaiting requested review from umutsoysalansys

@jrwest440 jrwest440 Awaiting requested review from jrwest440

Assignees

@mlkaplan36 mlkaplan36

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlkaplan36 @RobPasMue @pyansys-ci-bot