feat: commands for merge and intersect #1665
Draft
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean operations on body were executed using the core API. For a number of reasons it is agreed to switch to command based implementation which simplifies treatment of occurrences and fixes some known issues. Note that 1) Combine.Merge operation does not support keeping the other bodies 2) Subtract is invoked from Combine.Intersect passing subtract_from_target = true
remove files accidentally committed
|
@RobPasMue @jonahrb @b-matteo Leaving this PR in draft mode until the API server is updated, but feel free to review and add suggestions |
smereu
changed the title
Apply style change from pre-commit and correct undefined variable
…b.com/ansys/pyansys-geometry into feat/commands_for_merge_and_intersect
remove unnecessary files
Remove unnecessary files
smereu
changed the title
|
@smereu - please add yourself as "Assignee" of the PR and modify the PR description according to the guidelines whenever you get the chance. This allows us to properly maintain the repository and easily determine features and implementations |
…b.com/ansys/pyansys-geometry into feat/commands_for_merge_and_intersect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)