Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matrix operations #1649

Open
wants to merge 8 commits into
base: blitz
Choose a base branch
from
Open

feat: matrix operations #1649

wants to merge 8 commits into from

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Jan 16, 2025

Description

**utility functions for matrix operations that is to be handled on client side. This PR brings
1 - create a 4x4 transformation matrix based on two directional vectors, direction_x and direction_y. (Rotation Matrix)
2 - create a 4x4 transformation matrix based on origin and , direction. (Translation Matrix)
3 - create a 4x4 transformation matrix based combining translation and rotation matrices.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 16, 2025
@github-actions github-actions bot added the testing Anything related to tests label Jan 17, 2025
@RobPasMue RobPasMue changed the title matrix operations feat: matrix operations Jan 20, 2025
@RobPasMue
Copy link
Member

@umutsoysalansys - please modify the PR description according to the guidelines whenever you get the chance. This allows us to properly maintain the repository and easily determine features and implementations

tests/test_math.py Outdated Show resolved Hide resolved
@umutsoysalansys umutsoysalansys marked this pull request as ready for review January 22, 2025 17:36
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner January 22, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants