docs: add example notebooks for sweeps, map, and scale #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
github-actions
bot
added
the
documentation
github-actions
bot
added
documentation
jonahrb
reviewed
Mar 25, 2024
jonahrb
reviewed
Mar 25, 2024
| m = Modeler() | ||
| ``` | ||
|
|
||
| ## Scale Body |
There was a problem hiding this comment.
Only thoughts on the scale body section: maybe it would be better to make copies and scale the copies and plot them all together so the user can see the difference (plotting one body at a time doesn't have an immediate visual difference between them)
jonahrb
reviewed
Mar 25, 2024
jonahrb
reviewed
Mar 25, 2024
jonahrb
reviewed
Mar 25, 2024
| # Create the circlular profile on the XZ-plane centered at (5, 0, 0) with radius 2 | ||
| profile = Sketch(plane=Plane(direction_x=[1, 0, 0], direction_y=[0, 0, 1])).circle( | ||
| Point2D([path_radius, 0]), profile_radius | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| profile.plot() |
Might as well show the sketch in the plotter for better visualization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 93 93
Lines 6835 6835
=======================================
Hits 6167 6167
Misses 668 668 ☔ View full report in Codecov by Sentry. |
jonahrb
reviewed
Mar 25, 2024
|
@dastan-ansys - branch has to be named as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added example notebooks for sweep_sktech, sweep_chain, map, and scale.
Issue linked
Issue: 1049
Checklist
feat: extrude circle to cylinder)