-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exit call to avoid problems when building documentation #745
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 94.99% 94.97% -0.02%
==========================================
Files 109 109
Lines 5695 5696 +1
Branches 322 322
==========================================
Hits 5410 5410
- Misses 284 285 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be added to all examples running MAPDL - you can search for launch_mapdl
to find them.
@SRaimondi for the codecov check we can use our own judgement to ignore it - it will "fail" if the coverage reduces, or any of the changed lines is not covered in tests. But this can be caused by harmless changes like formatting, or here where the code is for the examples only. |
This PR adds an explicit
exit
call to the mapdl instance in the python documentation examples in order for it to not fail when building the documentation using the providedmake.bat
.