Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve module structure #404

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Improve module structure #404

merged 5 commits into from
Feb 8, 2024

Conversation

greschd
Copy link
Member

@greschd greschd commented Feb 7, 2024

Add submodules for example_helpers and material_property_sets.

@greschd greschd force-pushed the maint/improve_module_structure branch from 9a564a1 to d9f995c Compare February 7, 2024 15:26
@greschd
Copy link
Member Author

greschd commented Feb 7, 2024

To be discussed:

  • I didn't move server-related functionality to a submodule, because IMO (at least) launch_acp should be top-level
  • Any other functionality which should be moved down a level?

@greschd greschd linked an issue Feb 7, 2024 that may be closed by this pull request
Add some hierachy to the python module #361
Closed
@greschd greschd enabled auto-merge (squash) February 8, 2024 14:28
@greschd greschd merged commit fc14981 into main Feb 8, 2024
12 checks passed
@greschd greschd deleted the maint/improve_module_structure branch February 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvonrickenbach janvonrickenbach janvonrickenbach approved these changes

@roosre roosre Awaiting requested review from roosre roosre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some hierachy to the python module
2 participants
@greschd @janvonrickenbach