Adapt ACPWorkflow to embedded cdb file #395
Conversation
| h5_file_path: | ||
| The path to the h5 file. | ||
| acph5_file_path: | ||
| The path to the acph5 file. | ||
| """ | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
I wonder if the __init__ in this form still makes sense: its body is mostly just distinguishing between the different input file options.
Are we still expecting users to call this manually? Otherwise, we might as well directly use parameters local_file_path and format.
There was a problem hiding this comment.
No, I would expect users to only use the classmethod. I will implement your suggestion.
There was a problem hiding this comment.
Ok, it should probably also be mentioned in the class docstring to use the classmethods for construction.
There was a problem hiding this comment.
It is mentioned in the class docstring. Do you mean somewhere else?
There was a problem hiding this comment.
No, sorry I hadn't actually looked at the docstring 😅 you were ahead of me here.
| h5_file_path: | ||
| The path to the h5 file. | ||
| acph5_file_path: | ||
| The path to the acph5 file. | ||
| """ | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
No, sorry I hadn't actually looked at the docstring 😅 you were ahead of me here.
CDB file is now embedded in the acph5 file, so we build the workflow either from the cdb or the acph5 file. This currently does not support the use case of opening pre-existing acph5 files which don't yet have the cdb embedded. I would consider this a niche use-case since users currently don't typically work in standalone. If they do they can still just re-save the ACP model.