-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new credential entry point discovery #15685
Conversation
Linked PR was merged. This looks all intended, but non-obvious conflicts with #15638 for rebase |
e0353a2
to
007a760
Compare
d62e683
to
289209c
Compare
These collection test failures appear non-trivial to me.
Speculative, but I suspect that the way the tests are written may not be compatible with the changes to the plugins. Even with a rebase, I'm not sure this will be ready to merge yet. But I'll restart some tests to see if the new image fixes some failures. |
0c133ed
to
9e24367
Compare
The network cred tests in the awx collection integration tests are NOT picking up the new
|
I will open a separate PR to address the sanity fixes, we can ignore it. |
It's not just the sanity, the collection integration tests are expecting a credential type removed by this PR |
@@ -24,6 +24,28 @@ | |||
insights_cred_name1: "AWX-Collection-tests-credential-insights-cred1-{{ test_id }}" | |||
tower_cred_name1: "AWX-Collection-tests-credential-tower-cred1-{{ test_id }}" | |||
|
|||
- name: Get current Credential Types available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
817f19b
to
41c75fb
Compare
- add logic to check what version of the project is running #rename temp_var, remove old code and add validation check
* inventory source is covered in the workflow job template target * fix linting
5cf951b
to
b85c26b
Compare
Quality Gate passedIssues Measures |
SUMMARY
In ansible/awx-plugins#68, managed and supported creds are introduced.
This PR updates our logic to load the correct bucket of creds depending on what is installed.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This PR will not work until its corresponding PR is merged into awx-plugins but should be backwards compatible with the existing landscape of awx-plugins.