Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Update README.rst #229

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Update README.rst #229

merged 13 commits into from
Oct 31, 2023

Conversation

nikcode9
Copy link
Contributor

typos.

Copy link
Contributor

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.rst Outdated Show resolved Hide resolved
@nikcode9
Copy link
Contributor Author

i think it is better to have periods at end of each line here.

@Andersson007
Copy link
Contributor

i think it is better to have periods at end of each line here.

Could you please add them?

@gotmax23
Copy link
Contributor

Thanks for the contribution, @nikcode9. Can you explain more on your reasoning for this change? I don't think adding periods to these sentence fragments is correct.

@nikcode9
Copy link
Contributor Author

i have added periods where needed and also question marks which were not present. pls check @Andersson007

@Andersson007
Copy link
Contributor

Andersson007 commented Oct 25, 2023

Thanks for the contribution, @nikcode9. Can you explain more on your reasoning for this change? I don't think adding periods to these sentence fragments is correct.

@gotmax23 do you mean all or some of the changed sentences? If some, could you please specify them and why you think it's incorrect? To me it seems if a statement starts with a capital letter it should end with a period when it logically ends. I'm not an expert though.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor

@gotmax23 @russoz thanks!

@nikcode9 could you please take a look and press "Commit suggestion" where you agree and express your concerns where you disagree?

Copy link
Contributor Author

@nikcode9 nikcode9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

nikcode9 and others added 5 commits October 26, 2023 17:11
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
@Andersson007
Copy link
Contributor

@nikcode9 thanks!

@gotmax23 @russoz please take another look

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
nikcode9 and others added 2 commits October 26, 2023 21:15
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
@nikcode9
Copy link
Contributor Author

final changes done.

@gotmax23 gotmax23 merged commit ea63eba into ansible-collections:main Oct 31, 2023
1 check passed
@Andersson007
Copy link
Contributor

@nikcode9 thanks for the contribution!
@russoz @gotmax23 thanks for reviewing and merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants